[Webkit-unassigned] [Bug 35479] SVG fallback color doesn't work for bogus gradients.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35479





--- Comment #5 from Dirk Schulze <krit at webkit.org>  2010-03-01 11:13:05 PST ---
(In reply to comment #4)
> (In reply to comment #3)
> > (In reply to comment #2)
> > > Attachment 49685 [details] [details] [details] did not pass style-queue:
> > > 
> > > Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1
> > > WebCore/svg/graphics/SVGPaintServer.cpp:129:  Tests for true/false,
> > > null/non-null, and zero/non-zero should all be done without equality
> > > comparisons.  [readability/comparison_to_zero] [5]
> > > Total errors found: 1 in 9 files
> > > 
> > > 
> > > If any of these errors are false positives, please file a bug against
> > > check-webkit-style.
> > 
> > I check if the size is zero, negative values are allowed. I had problems with
> > this rule multiple times now, can't we get rid of it?
> 
> Instead of
>   item->objectBoundingBox().width() != 0
> why can't it just be
>   item->objectBoundingBox().width()
> ?

Even if we give a warning for negative values (eg. negative with or height on a
rect=, we still render this objects. If I make
item->objectBoundingBox().width(), all negative values would cause a stroke of
a path with black, insteaf of a gradient. This isn't correct in my opinion.
That's why it has to be != 0

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.