[Webkit-unassigned] [Bug 30144] MIPS JIT Supports

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=30144


Gavin Barraclough <barraclough at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49551|review?                     |review-
               Flag|                            |




--- Comment #48 from Gavin Barraclough <barraclough at apple.com>  2010-03-01 11:09:44 PST ---
(From update of attachment 49551)
Hi Chao-ying,

Many apologies, I thought I'd added a review last week, I guess I must have
failed to hit commit.
Assuming you've fixed Gabor's review issues I'm happy, these changes look good
to land. However, as raised in my previous review, I'll like to see this landed
in two tranches.

You should be able to land yarr support with just the changes in assembler,
yarr, jit/ExecutableAllocator.h, and some of the changes to wtf/Platform.h.

Please put up a patch with just these changes & I'll be happy to r+.

cheers,
G.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.