[Webkit-unassigned] [Bug 35210] [Gtk] implements ChromeClient::requestGeolocationPermissionForFrame

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35210


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49676|review?                     |review-
               Flag|                            |




--- Comment #18 from Gustavo Noronha (kov) <gns at gnome.org>  2010-03-01 10:48:46 PST ---
(From update of attachment 49676)
 20 #include "config.h"
 21 
 22 #include "webkitgeolocationpolicydecision.h"
 23 
 24 #include "webkitprivate.h"
 25 
 26 #include "Geolocation.h"

These spaces are wrong. You should have this, instead:

 #include "config.h"
 #include "webkitgeolocationpolicydecision.h"

 #include "Geolocation.h"
 #include "webkitprivate.h"

 65 
 66 
 67     priv->frame = frame;

Too many empty lines here.

 78  * Since: 1.1.22

These should be 1.1.23, now =)

Except for these, I think this should be good to go.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.