[Webkit-unassigned] [Bug 18282] WebKit crashes with deeply nested divs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=18282





--- Comment #37 from TAMURA, Kent <tkent at chromium.org>  2010-03-31 23:46:58 PST ---
(In reply to comment #36)
> Created an attachment (id=52263)
 --> (https://bugs.webkit.org/attachment.cgi?id=52263) [details]
> Proposed patch by tkent (rev.4)

This patch contains a change for cap by DOM operation, and removed a change for
cap by parsers because the DOM operation got much faster than the past patches.

fast/dom/tree-depth-cap.html takes 2.93sec on my machine, and
fast/parser/tree-depth-cap.html takes 0.47sec.  I think
fast/dom/tree-depth-cap.html is not acceptable to check in.

* Performance
** Doromaeo DOM
- No patch http://dromaeo.com/?id=98854
  createElement: 545.00runs/s ±0.70%
  createTextNode: 272.29runs/s ±1.08%
  innerHTML: 78.90runs/s ±0.47%
  cloneNode: 146.59runs/s ±2.33%
  appendChild: 1023.00runs/s ±0.49%
  insertBefore: 958.60runs/s ±0.54%

- With this patch http://dromaeo.com/?id=98855
  createElement: 532.88runs/s ±0.89%    * This should not have performance
difference.
  createTextNode: 263.83runs/s ±0.95%  * ditto.
  innerHTML: 78.56runs/s ±0.32%
  cloneNode: 143.58runs/s ±5.47%
  appendChild: 1059.60runs/s ±0.13%
  insertBefore: 998.40runs/s ±0.64%


** Performance checker in this bug
Iteration=4,000 depth=200
No patch: 4,808
This patch: 4.982 (3.6% time gain)

Iteration=500 depth=1,000
No patch: 7,160
This patch: 7,315 (2.1% time gain)

Iteration=30 depth=4,000
No patch: 5,623
This patch: 5,706 (1.4% time gain)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.