[Webkit-unassigned] [Bug 36911] Add webkit-patch command to crawl buildbot history and find when tests started to fail
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Mar 31 18:06:46 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=36911
Adam Barth <abarth at webkit.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |abarth at webkit.org
--- Comment #2 from Adam Barth <abarth at webkit.org> 2010-03-31 18:06:46 PST ---
+ raise "Unhandled title: %s" % str(table_title)
We should only be raising Exception objects. Better to raise an Exception().
+ def _print_blame_information_for_commit(tool, commit_info):
This should be in a base class? Maybe on CommitInfo? Having a random global
function seems strange.
+ class FailureReason(AbstractDeclarativeCommand):
This class is kind of lame. It makes it really hard to re-use this logic or to
test it. Maybe we need a FailureWalker class?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list