[Webkit-unassigned] [Bug 36882] [chromium] traverse from WebApplicationCacheHost to its associated WebDataSource and ultimately to its containing WebFrame

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36882





--- Comment #7 from jochen at chromium.org  2010-03-31 14:42:31 PST ---
(In reply to comment #6)
> Darin had a good suggestion for how to establish the frame/datasource/appcache
> relationships. Instead of adding a WebFrame param to the factory method, move
> the createApplicationCacheHost() method from WebKitClient to WebFrameClient.
> That interface has a handful of similar factory methods that take a WebFrame
> param.
> 
> So we'd have...
> 
> WebFrameClient::createApplicationCacheHost(
>   WebFrame*, WebDataSource*, WebApplicationCacheHostClient*);
> 
> ... at the time of WebApplicationCacheHost construction (its done lazily in
> maybeLoadMainResource), we're guaranteed to know what our WebCore::Frame is.
> 
> 
> And we wouldn't need the WebDataSource.frame() method which Darin wants to
> avoid introducing.

what do we need the datasource for then? All I need to send the notification
around is the render_view_id of the frame, e.g.

RenderView::FromWebView(frame->view())->routing_id(). This information is
extracted on construction of the WebApplicationCacheHost (see
http://codereview.chromium.org/1600002 )

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.