[Webkit-unassigned] [Bug 36802] setting document.title doesn't change document.title value

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36802


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52137|review?                     |review+
               Flag|                            |




--- Comment #7 from Darin Adler <darin at apple.com>  2010-03-31 13:00:12 PST ---
(From update of attachment 52137)
> +        When HTMLTitleElement::setText() is called reentrant manner by
> +        Document::seTitle(), the argument of setText() changes implicitly.

Typo: "Document:seTitle".

> +description("This test checks to see if setting documen.title works even if the title element has multiple children.");

Typo here: "documen"

> +        // We make a copy here because value.m_impl will be changed implicitly during removeChildren(),
> +        // which causes HTMLTitleElement::childrenChanged(), which ends up Document::setTitle().
> +        String valueCopy(value);

The comment is a little confusing because strings are immutable. The real issue
is that value is a reference to a string from the DOM tree.

But given the special case this patch added above for empty values and no
children, I don't think this second code change actually matters. Could you
test without this second change? I believe only the isEmpty change is needed.

I'm going to say review+, though. This seems slightly flawed, but OK. The test
is the best part!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.