[Webkit-unassigned] [Bug 36874] Cleanup RedirectScheduler

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Mar 31 10:01:47 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=36874


Darin Fisher (:fishd, Google) <fishd at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52144|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #7 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2010-03-31 10:01:46 PST ---
(From update of attachment 52144)
> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> +        Cleanup RedirectScheduler
> +        https://bugs.webkit.org/show_bug.cgi?id=36874
> +
> +       Removed the nutty ScheduledRedirection struct in favor of a hierarchy

^^^ bad indentation

otherwise, this all looks good to me.  given the naming of the file, it seems
like it would be nice if the base interface were named ScheduledRedirect, but
I realize why you chose not to do that.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list