[Webkit-unassigned] [Bug 31680] WebCore::Document::updateLayoutIgnorePendingStylesheets NULL pointer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31680





--- Comment #20 from MORITA Hajime <morrita at google.com>  2010-03-30 22:29:02 PST ---
Darin, ap, thank you for reviewing and for your suggestion!
I updated the patch.

> (From update of attachment 52021 [details])
> Alexey pointed out what we should really be doing. This should not just be
> about null checking.
> (snip)
> Instead of checking for null we should check that the node is in the document
> of m_frame. It's not OK to set this to a node in another document.
Requiring m_frame->document() == node->document()  is too strict and
Doing so will break following tests: 

- editing/selection/4960137.html
- editing/selection/drag-in-iframe.html

These tests expect DOMSelection::setBaseAndExtent() to redirect operations to
owner 
document of the argument node, instead of the document of the DOMSelection. 
Although these redirection was done inside SelectionController::setSelection(), 
This change do it inside DOMSelection to clarify intension.
This change also redirect other DOMSelection API with Node as an argument for
consistency.
(And added DOMSelection::findControllerFor() to choose the destination of  the
redirection.)

I hope I would remove code for implicit redirection from SelectionController
and 
allow SelectionController to assume its operation closed inside the single
document.
But SelectionController is called from many place (especially editing) and 
such cleanup looks difficult at this time. So This change keeps it as is.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.