[Webkit-unassigned] [Bug 35072] [Mac] Move Icon::iconForFiles() code to WebChromeClient::iconForFiles().

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35072





--- Comment #17 from TAMURA, Kent <tkent at chromium.org>  2010-03-30 19:15:03 PST ---
(In reply to comment #16)
> This patch (http://trac.webkit.org/changeset/56439) caused a major regression
> (https://bugs.webkit.org/show_bug.cgi?id=36723)
> 
> Since:
> 1 - It didn't change functionality
> 2 - The approach was generally not liked.
> 3 - In general, round tripping between WebCore and WebKit is something we try
> to *reduce*
> 
> ...I think it needs to be rolled out.

Brady, I already post a fix for the regression.  Please don't roll it out.
Even if we rolled it out, the problem would not be solved with platforms of
which Icon::iconForFiles() returns 0.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.