[Webkit-unassigned] [Bug 36865] New: path to committers.py in commit-queue rejection message is wrong

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36865

           Summary: path to committers.py in commit-queue rejection
                    message is wrong
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
                CC: abarth at webkit.org, cjerdonek at webkit.org


path to committers.py in commit-queue rejection message is wrong

Right now it's hardcoded in CommitterValidator (inside bugzilla.py)

        committer_list = "WebKitTools/Scripts/webkitpy/committers.py"

I havne't yet found the magic for computing the __file__ dynamically.

You can get the __file__ from a module object, but we import just the class and
not the module.

You can get the module name (string) from classname.__module__ or
instance.__class__.__module__

But I don't yet know how to get to the actual module object.

If we moved towards a model where we used:
import committers

statements instead of:

from committers import CommitterList

then we could easily just grab "committers.__file__" and be done. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.