[Webkit-unassigned] [Bug 36841] test-webkitpy needs full module path to run tests now

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36841





--- Comment #2 from Chris Jerdonek <cjerdonek at webkit.org>  2010-03-30 13:57:42 PST ---
(In reply to comment #0)
> test-webkitpy GitTest.test_commit_text_parsing should (and used to) work. Now I
> need to do: test-webkitpy
> webkitpy.common.checkout.scm_unittest.GitTest.test_commit_text_parsing

Note that there was something about the previous implementation that didn't
work.

Because we were calling "import *" for every one of our unit test modules, if
the name of any test class matched the name of any other test class, the tests
for the latter class would silently overwrite the tests of the former (with no
error, etc).  The first time I noticed something similar to this was when I
noticed two unit test methods in cpp_unittest with the same name while
refactoring:

https://bugs.webkit.org/show_bug.cgi?id=33684#c19 (see towards end of comment)

(That was for test method name collisions though rather than test class name
collisions.)

The current implementation doesn't have this problem (for class names) because
the unit-test classes are getting imported with their namespaces attached.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.