[Webkit-unassigned] [Bug 31680] WebCore::Document::updateLayoutIgnorePendingStylesheets NULL pointer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31680


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52021|review?                     |review-
               Flag|                            |




--- Comment #17 from Darin Adler <darin at apple.com>  2010-03-30 12:04:44 PST ---
(From update of attachment 52021)
Alexey pointed out what we should really be doing. This should not just be
about null checking.

> +    if (node && !node->document()) {
> +        ec = INVALID_ACCESS_ERR;
> +        return;
> +    }

Instead of checking for null we should check that the node is in the document
of m_frame. It's not OK to set this to a node in another document.

> +    if ((baseNode && !baseNode->document()) 
> +        || (extentNode && !extentNode->document())) {
> +        // We don't know how to "select" ownerless nodes.
> +        ec = INVALID_ACCESS_ERR;
> +        return;
> +    }

Same comment.

> +    if (node && !node->document()) {
> +        ec = INVALID_ACCESS_ERR;
> +        return;
> +    }

Same comment.

> +    if (!node->document()) {
> +        ec = INVALID_ACCESS_ERR;
> +        return;
> +    }

Ditto.

> -    if (!n || selection->isNone())
> +    if (!n || !n->document() || selection->isNone())
>          return false;

Again.

> +    if (!n->document()) {
> +        ec = INVALID_ACCESS_ERR;
> +        return;
> +    }

Again.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.