[Webkit-unassigned] [Bug 36830] IndexedDB: Finish hooking up bindings for IndexedDatabaseRequest

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36830


Nate Chapin <japhet at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #52044|review?                     |review+
               Flag|                            |




--- Comment #2 from Nate Chapin <japhet at chromium.org>  2010-03-30 11:33:45 PST ---
(From update of attachment 52044)
r+ with a nit.

> +private:
> +    V8CustomIDBCallbacks(v8::Local<v8::Value> onSuccess, v8::Local<v8::Value> onError, Frame* frame)
> +        : m_onSuccessNull(!onSuccess->IsObject())
> +        , m_onSuccess(v8::Persistent<v8::Object>::New(onSuccess->ToObject()))
> +        , m_onErrorNull(!onError->IsObject())
> +        , m_onError(v8::Persistent<v8::Object>::New(onError->ToObject()))
> +        , m_frame(frame)
> +    {
> +    }
> +
> +    // FIXME: Should these be v8::Functions?  For some reason, VoidCallback (which this copied) uses v8::Objects.
> +    bool m_onSuccessNull;
> +    v8::Persistent<v8::Object> m_onSuccess;
> +    bool m_onErrorNull;

Why do we need separate bools here?  It seems like unnecessary duplication of
information to me.

> +    v8::Persistent<v8::Object> m_onError;
> +    RefPtr<Frame> m_frame;
> +};
> +
> +}
> +
> +#endif
> +
> +#endif // V8CustomIDBCallbacks_h

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.