[Webkit-unassigned] [Bug 36466] audio engine: add Reverb class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36466


Jeremy Orlow <jorlow at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51976|review?                     |review+
               Flag|                            |




--- Comment #12 from Jeremy Orlow <jorlow at chromium.org>  2010-03-30 07:33:11 PST ---
(From update of attachment 51976)
r=me, but as with the other engine patches, this should go into the branch.


> +void Reverb::process(AudioBus* sourceBus, AudioBus* destinationBus, size_t framesToProcess)
> +{
> +    // Do a fairly comprehensive sanity check.
> +    // If these conditions are satisfied, all of the source and destination pointers will be valid for the various matrixing cases.
> +    bool isSafeToProcess = sourceBus && destinationBus && sourceBus->numberOfChannels() > 0 && destinationBus->numberOfChannels() > 0
> +        && framesToProcess <= MaxFrameSize && framesToProcess <= sourceBus->frameSize() && framesToProcess <= destinationBus->frameSize(); 

nit: probably better to line up on |sourceBus|

i.e.

    bool isSafeToProcess = sourceBus && destinationBus &&
sourceBus->numberOfChannels() > 0 && destinationBus->numberOfChannels() > 0
                           && framesToProcess <= MaxFrameSize &&
framesToProcess <= sourceBus->frameSize() && framesToProcess <=
destinationBus->frameSize();

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.