[Webkit-unassigned] [Bug 36814] [DRT/Chromium] Add TestShell and WebViewHost class, main(), and so on

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Mar 30 03:12:14 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=36814


TAMURA, Kent <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|webkit-bot-watchers at googleg |dglazkov at chromium.org,
                   |roups.com,                  |fishd at chromium.org
                   |webkit.review.bot at gmail.com |
             Blocks|                            |35902




--- Comment #3 from TAMURA, Kent <tkent at chromium.org>  2010-03-30 03:12:13 PST ---
Sorry for the very huge patch.
These files are related to each other strongly.

(In reply to comment #2)
> WebKitTools/DumpRenderTree/chromium/config.h:38:  Streams are highly
> discouraged.  [readability/streams] [3]
> WebKitTools/DumpRenderTree/chromium/DumpRenderTree.cpp:33:  Found other header
> before a header this file implements. Should be: config.h, primary header,
> blank line, and then alphabetically sorted.  [build/include_order] [4]
> Total errors found: 2 in 8 files

These style errors are expected, and I think we can't avoid them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list