[Webkit-unassigned] [Bug 21371] Cannot animate "points" attribute for <svg:polygon>

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=21371


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51885|review?                     |review+
               Flag|                            |




--- Comment #9 from Nikolas Zimmermann <zimmermann at kde.org>  2010-03-30 01:35:03 PST ---
(From update of attachment 51885)
Nice patch, some small comments before landing:

> Index: WebCore/svg/SVGPathSegList.h
> ===================================================================
> --- WebCore/svg/SVGPathSegList.h	(revision 56693)
> +++ WebCore/svg/SVGPathSegList.h	(working copy)
> @@ -45,6 +45,8 @@ namespace WebCore {
>          SVGPathSegList(const QualifiedName&);
>      };
>  
> +    float blendFunc(float from, float to, float progress);

Can you rename this function to something more descriptive?



> Index: WebCore/svg/SVGPointList.cpp

> +        const FloatPoint from = fromList->getItem(n, ec);
> +        const FloatPoint to = toList->getItem(n, ec);
Can't you omit const here?

Excellent testcase, r=me.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.