[Webkit-unassigned] [Bug 31680] WebCore::Document::updateLayoutIgnorePendingStylesheets NULL pointer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31680





--- Comment #12 from MORITA Hajime <morrita at google.com>  2010-03-29 19:09:53 PST ---
darin, ap, thank you for reviewing!

>But it seems wrong that such a node even ends up in Position. Perhaps it would
>be a better fix to ensure that this doesn't happen, I'm not sure. The place to
>make the check would be setBaseAndExtent(), and other functions in DOMSelection
>may need checks (and regression tests), too.

>The fact that DocumentType nodes have no document stinks. The question is where
>to guard against these types of nodes. To me, canonicalPosition seems a bit
>low-level a place to be doing the check. I worry there are other leaf functions
>that lack this. It might be better to guard this incoming at places where nodes
are passed in.

I agreed these concern and added a guard on setBaseAndExtent().
A guard on canonicalPosition() has kept as is because 
VibiblePosition is used many places on editing area and 
It looks safe to guard it anyway.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.