[Webkit-unassigned] [Bug 26224] [Qt, Gtk] Allows build-webkit script to receive an install prefix as parameter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26224


Gustavo Noronha (kov) <gns at gnome.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51921|review?                     |review-
               Flag|                            |




--- Comment #22 from Gustavo Noronha (kov) <gns at gnome.org>  2010-03-29 16:11:04 PST ---
(From update of attachment 51921)
 2841         headers.path = $$INSTALL_PREFIX/include/qt4/QtWebKit
 2842     target.path = $$INSTALL_PREFIX/lib

This seems to be indented poorly. Tabs?

 222   --prefix=<PREFIX>                 Install files in PREFIX
221223   --makeargs=<arguments>            Optional Makefile flags

--makeargs uses a lower-cased argument place-holder, perhaps we should keep
this consistent. You could use <path>, for instance. This still misses an
indication that this only affects some ports, I think.

Except for these two nits, the GTK+ part of it looks good to me. I'll r- since
you're not a committer, and we'll need an updated patch anyway. If someone
wants to look at the Qt changes, and say r+ when these nits are addressed, the
GTK+ side looks good, like I said =).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.