[Webkit-unassigned] [Bug 36466] audio engine: add Reverb class

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36466





--- Comment #10 from Chris Rogers <crogers at google.com>  2010-03-29 15:37:49 PST ---
> Is it possible for the normalization scale to ever ben 0?  If so, is there some
> better default action we can take here?

It is possible if the user un-intentionally (or intentionally in some cases)
loads up an impulse response which represents "dead silence".  In this case,
the code will work correctly (do the mathematically correct thing)  and
generate silent output.  That said, there is the opportunity for an
optimization in this case (avoid doing the convolution altogether and simply
note this edge case and zero out the destination buffers directly).  But I
think the case is rare enough that an optimization isn't really necessary and
would actually make the code a little harder to read.

> I think that would help.  And I'd encourage you to check as many assumptions as
> are possible with some sort of fatal assert.

I did change ReverbConvolver::process() to take AudioChannels (instead of raw
pointers).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.