[Webkit-unassigned] [Bug 33696] let's cache nodelists instead of dynamicnodelist::cache

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 29 10:51:22 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=33696





--- Comment #75 from anton muhin <antonm at chromium.org>  2010-03-29 10:51:21 PST ---
(In reply to comment #73)
> (In reply to comment #68)
> > (In reply to comment #64)
> > > (In reply to comment #50)
> > > > I had one other idea. It might be better for performance if the rare data bit
> > > > check was inlined. We should do that in a follow-up patch.
> > > 
> > > Is not it inlined already (if you mean hasRareData())?
> > 
> > In JSNode::markChildren, we make a function call to markCachedNodeLists. I was
> > looking for a code change to make sure it markChildren makes no function call
> > in the common case where hasRareData() is false.
> 
> I see, thanks.  Let me give it a try.

Check inlined.  I experimented with nodeLists fetching but that requires
NodeRareData.h include which conflicts with export headers.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list