[Webkit-unassigned] [Bug 36760] New: check-webkit-style shouldn't complain about namespace indents in forward declarations

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Mar 29 09:16:26 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=36760

           Summary: check-webkit-style shouldn't complain about namespace
                    indents in forward declarations
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: abarth at webkit.org


--- Comment #70 from Darin Adler <darin at apple.com>  2010-03-29 09:07:38 PST ---
(In reply to comment #69)
> > > Done, but now style checking script barks at me.
> >
> > Bug in the script.
>
> Is it?
>
> +namespace JSC {
> +
> +    class JSGlobalData;
> +    class MarkStack;
> +
> +}
>
> versus Rule #3 <http://webkit.org/coding/coding-style.html>?

There's nothing specific in the coding style document to make it clear that
indenting is desirable in forward declarations as opposed to the actual code
defined in a header.

But there should be.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list