[Webkit-unassigned] [Bug 36315] Remove obsolete Geolocation::m_currentPosition

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36315





--- Comment #6 from Marcus Bulach <bulach at chromium.org>  2010-03-29 08:05:11 PST ---
(In reply to comment #3)
> (From update of attachment 51091 [details])
> +        Remove obsolete Geolocation::m_currentPosition
> +        (follow up on https://bugs.webkit.org/show_bug.cgi?id=30676)
> tabs
> 

Ops, fixed.

> Looks good to me otherwise. To further clarify the code, we could remove the
> Geoposition argument from positionChanged() and hence setPosition(). Instead,
> positionChanged() would just call m_service->lastPosition() directly. This
> would also bring the client-based code path in line with the existing code
> path. 

Hmm, I don't quite understood this bit: setPosition is part of the public API,
I'm not sure if I can just remove GeolocationPosition (not Geoposition) from
it. If you're saying to remove only from the call to positionChanged(), that
would require pushing up
"m_positionCache->setCachedPosition(newPosition.get());" to the two APIs.

Since this would be just a further clarification, I hope you don't mind if I do
as a follow up?

> 
> Also, I think that in a future change we should remove m_lastPosition, as it
> serves no purpose as far as I can see.

Agreed. Right now, it only serves to ensure ownership of either the service or
client-based geoposition, but clarifying it would definitely be a good idea.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.