[Webkit-unassigned] [Bug 36394] Include git commits in the diff for webkit-patch upload/land.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36394





--- Comment #20 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2010-03-28 20:05:25 PST ---
(In reply to comment #17)
> (In reply to comment #16)
> > Maybe a --squash option would let folks use both workflows?  It could be an
> > option on both upload and land.
> 
> I don't understand what the other workflow is. When is the current workflow
> ever superior to the squash workflow?
> 
> The current workflow requires all your changes to be in the working copy. The
> new one lets you continue doing that if you want, but also lets you have
> committed changes. In theory, the current workflow lets you have local commits
> that you don't want to upload, but why is that useful if committing to SVN will
> commit all your local commits as well?
> 
> Adding it isn't a big deal I guess, except for maintenance overhead for a
> feature that probably won't get used. I would want it to at least default to
> true.

I know I'm in the minority, but I don't want webkit-patch squashing my commits
or otherwise modifying my git repository, other than to update placeholders for
reviewers (or bug numbers) before it lands local commits individually.

If I wanted commits squashed, I will do it myself.  Likewise I wouldn't have
local changes when running webkit-patch--I would have committed them (usually
on a branch) before I ran the command.  I tend to have multiple patches in
progress on different branches in my git repo, so local changes don't make much
sense in that scenario.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.