[Webkit-unassigned] [Bug 36395] [Qt] Patch to add support for Content-Disposition...

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36395





--- Comment #31 from adawit at kde.org  2010-03-28 17:36:06 PST ---
(In reply to comment #30)
> (From update of attachment 51644 [details])
> Patch looks good to me, but before landing we have to preserve Google's
> copyright when moving the function!
> 
> Also we still don't have a test for this :-(

Looked into adding a test case for this, but do not know where to begin. I most
definitely need help in adding a test case for this. My test of the patch was
exclusively done using kwebkitpart which passes all the tests in the link I
gave in my original report. Ofcourse that is not relevant for qtwebkit. Anyhow,
I need help with creating the test case...

> Dawit, do you want to follow up with a patch that removes the original from
> WebKit/chromium and makes it use the new function from WebCore?

Actually I provided a patch to chromium's source tree in the 51392 attachment
but I retracted it thinking I was not supposed to do that... Anyhow, I most
definitely can provide an updated patch with the chromium source tree change ;
specially since I have finally relented and cloned the qtwebkit git repository.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.