[Webkit-unassigned] [Bug 36714] run-webkit-tests --exit-after-N-failures did not catch infinite crasher

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36714


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |aroben at apple.com,
                   |                            |ddkilzer at webkit.org




--- Comment #1 from Eric Seidel <eric at webkit.org>  2010-03-27 17:52:42 PST ---
I'm not sure I understand run-webkit-tests well enough to know.

It looks like this early exit from teh loop:

720        unless ($readResults->{status} eq "success") {
721            my $crashed = $readResults->{status} eq "crashed";
722            testCrashedOrTimedOut($test, $base, $crashed, $actual, $error);
723            countFinishedTest($test, $base, $crashed ? "crash" : "timedout",
0);
724            next;
725        }

is causing us to skip the exitAfterNFailures block:

2        # --reset-results does not check pass vs. fail, so exitAfterNFailures
makes no sense with --reset-results.
973        if ($exitAfterNFailures && !$resetResults) {
974            my $passCount = $counts{match} || 0; # $counts{match} will be
undefined if we've not yet passed a test (e.g. the first test fails).
975            my $failureCount = $count - $passCount; # "Failure" here
includes new tests, timeouts, crashes, etc.
976            if ($failureCount >= $exitAfterNFailures) {
977                print "\nExiting early after $failureCount failures. $count
tests run.";
978                closeDumpTool();
979                last;
980            }
981        }

I don't have a suggested fix yet, but I believe the above explains why this
infinite crasher hung the commit-queue (and would have hung the bots)!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.