[Webkit-unassigned] [Bug 26224] [Qt, Gtk] Allows build-webkit script to receive an install prefix as parameter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26224





--- Comment #16 from Antonio Gomes (tonikitoo) <tonikitoo at webkit.org>  2010-03-27 05:45:28 PST ---
(In reply to comment #15)
> Created an attachment (id=51793)
 --> (https://bugs.webkit.org/attachment.cgi?id=51793) [details]
> Previous patch rebased and added more changes.
> 
> Previous patch rebased and added more changes.

belem, patch looks Ok overall, but there are some requirement for all WebKit
patches.

It needs a ChangeLog entry. For that run WebKitTools/Scripts/prepare-ChangeLog
--bug 26224

It will create a ChangeLog entry in WebKitTools/ChangeLog . There you put the
more details you can, explaining the change.

Also there is not need to sign-off patches. You add can add something like 

"Based on the previous work of André Pedralho <andre.pedralho at openbossa.org>" 

or 

"Patch by Rodrigo Belem <email at here.xxx> and
          Andre Pedralho <email at here.xxx> on 2009-09-07
"

or even

"2009-09-08  Rodrigo Belem <email at here.xxx>, Andre Pedralho <email at here.xxx>"

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.