[Webkit-unassigned] [Bug 36698] New: There is a build break due to the disabled() when wml is enabled.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36698

           Summary: There is a build break due to the disabled() when wml
                    is enabled.
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: UNCONFIRMED
          Severity: Normal
          Priority: P2
         Component: New Bugs
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: gyuyoung.kim at samsung.com



Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51823|                            |review?
               Flag|                            |


Created an attachment (id=51823)
 --> (https://bugs.webkit.org/attachment.cgi?id=51823)
Patch for a build break due to the disabled() funciton

There is a build break due to the disabled() when wml is enabled. It seems that
this break comes from the Bug 35056 - Disabled menu options are still
submitted. 

WMLOptionElement class is a child class of OptionElement class as below. So, if
a virtual function is added to OptionElement, WMLOptionElement class should
defines that function as well.

  class WMLOptionElement : public WMLFormControlElement, public
WMLEventHandlingElement, public OptionElement {



My modification is as below,

--- WebCore/wml/WMLOptionElement.h      (revision 56658)
+++ WebCore/wml/WMLOptionElement.h      (working copy)
@@ -41,6 +41,8 @@ public:
     virtual void childrenChanged(bool changedByParser = false, Node*
beforeChange = 0, Node* afterChange = 0, int childCountDelta = 0);
     virtual void parseMappedAttribute(MappedAttribute*);

+    virtual bool disabled() const { return false; };
+

I think diabled() should be added to WMLOptionElement.h.

Thank you,
Gyuyoung Kim.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.