[Webkit-unassigned] [Bug 36692] Redo the file:// origin separation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36692


Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51809|review?                     |review-
               Flag|                            |




--- Comment #5 from Adam Barth <abarth at webkit.org>  2010-03-27 00:51:14 PST ---
(From update of attachment 51809)
+ return String("file://") + m_filePath;

This code seems wrong.  This value is exposed to web content.  We want the
current value, not the extended value.

+ if (isLocal() && (m_enforceFilePathSeparation ||
other->m_enforceFilePathSeparation) && m_filePath != other->m_filePath)

This code is copy/pasted.  Whenever you copy/paste code, you should consider
how to abstract it do you don't have to repeat yourself.

Other than that, this looks ok.  Do you want to add a test for the about:blank
that caused us to go down this path?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.