[Webkit-unassigned] [Bug 36649] operator== and operator!= for Position is not used

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36649





--- Comment #4 from Ryosuke Niwa <rniwa at webkit.org>  2010-03-26 15:19:06 PST ---
(In reply to comment #2)
> I think I wrote them in hopes of wider position deployment.

I see your point that VisiblePosition might need to go away at some point, but
we probably need to other refactoring in advance. In particular, we should
first get rid of functions / editing commands (IndentOutdentCommand,
InsertListCommmand, moveParagraph, etc...) that change selection to modify
ranges.  It'll probably takes years to this refactoring because they're heavily
depended on by a large portion of editing code.  If we had started replacing
VisiblePosition by Position now, we'll end up mixing code that directly
manipulates Position, VisiblePosition, and Selection simultaneously and that's
very nasty.

For example, moveParagraphWithClones currently uses setEndSelection at
http://trac.webkit.org/browser/trunk/WebCore/editing/CompositeEditCommand.cpp#L851
but if we had a version of deleteSelection that didn't rely on selection, we
would be able to call this function without having to restore the selection
afterwards.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.