[Webkit-unassigned] [Bug 36394] Include git commits in the diff for webkit-patch upload/land.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36394


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51443|review?                     |review-
               Flag|                            |




--- Comment #18 from Eric Seidel <eric at webkit.org>  2010-03-26 14:08:05 PST ---
(From update of attachment 51443)
I would rather pass a revision to prepare-ChagneLog to diff against so that you
dont' have to compute the remote branch twice in two languages.

 131     print STDERR "  --full-diff    Populate the ChangeLogs from the full
diff from trunk including local commits\n";

519520     def commit_with_message(self, message, username=None):

needs to be broken into little _ helper functions for my little brain to have a
prayer of understanding.

I thought we had some helper function for running git config?
 588         remote = run_command(['git', 'config', 'svn-remote.svn.fetch'])

Maybe that's in credentials.py?  If so it probably should re-use code in
scm.Git

%s is always better than + imo:
 607             args.append(self.svn_branch_name() + '..HEAD')

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.