[Webkit-unassigned] [Bug 36665] [v8] Page Cache does not work on Android

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 26 12:47:44 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=36665





--- Comment #9 from Andrei Popescu <andreip at google.com>  2010-03-26 12:47:43 PST ---
Thanks a lot for the r+ :)

(In reply to comment #8)
> (From update of attachment 51769 [details])
> + namespace WebCore {
> 
> We usually like a blank line after the namespace declaration.
> 
> I don't see restore() or clear() called anywhere.  Maybe that's for a future
> patch?

Oh, they are called already by WebCore's page cache mechanism:

http://trac.webkit.org/browser/trunk/WebCore/history/CachedFrame.cpp#L85
and
http://trac.webkit.org/browser/trunk/WebCore/history/CachedFrame.cpp#L196

Thanks,
Andrei

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list