[Webkit-unassigned] [Bug 33696] let's cache nodelists instead of dynamicnodelist::cache

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=33696





--- Comment #38 from Darin Adler <darin at apple.com>  2010-03-26 10:11:09 PST ---
(In reply to comment #37)
> I am more concerned why after GC it disappears, but suspect that JSC bindings
> just discard cached nodelist due to some kind of weak references.
> 
> Does that make sense?

Yes that's excellent analysis, and it points out a needed code change.

Since we are going to extend the lifetime of the the node lists we need to
extend the lifetime of their JavaScript wrappers too. The right place to do
that is the JSNode::markChildren file in JSNodeCustom.cpp, near the top. The
code should get at the NodeListsNodeData structure, walk the hash tables, and
call markDOMObjectWrapper on each NodeList*.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.