[Webkit-unassigned] [Bug 35530] Enum value FORWARD, BACKWARD, RIGHT, LEFT are causing macro conflicts.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35530


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51713|review?                     |review-
               Flag|                            |




--- Comment #28 from Darin Adler <darin at apple.com>  2010-03-26 09:15:13 PST ---
(From update of attachment 51713)
>  #include "AXObjectCache.h"
>  #include "ApplyStyleCommand.h"
> -#include "CharacterNames.h"
> -#include "CompositionEvent.h"
> -#include "CreateLinkCommand.h"
>  #include "CSSComputedStyleDeclaration.h"
>  #include "CSSMutableStyleDeclaration.h"
>  #include "CSSProperty.h"
>  #include "CSSPropertyNames.h"
>  #include "CSSValueKeywords.h"
> +#include "CharacterNames.h"
>  #include "ClipboardEvent.h"
> +#include "CompositionEvent.h"
> +#include "CreateLinkCommand.h"
>  #include "DeleteButtonController.h"
>  #include "DeleteSelectionCommand.h"
>  #include "DocLoader.h"

This is incorrect. The coding style specifies:

    "#include statements should be in sorted order (case sensitive, as done by
the command-line sort tool or the Xcode sort selection command)."

You have changed them from case sensitive sort order to a different sort order.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.