[Webkit-unassigned] [Bug 36654] MediaPlayer supports only one MediaPlayerPrivateInterface implementation

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36654





--- Comment #6 from Philippe Normand <pnormand at igalia.com>  2010-03-26 08:19:28 PST ---
(In reply to comment #5)
> (In reply to comment #4)
> > (In reply to comment #3)
> > > (In reply to comment #2)
> > > > I guess I can rename MediaPlayerPrivate in the gstreamer backend to
> > > > MediaPlayerPrivateGStreamer :)
> > > > 
> > > > Renaming would be needed in other implementations as well.
> > > 
> > > MediaPlayerPrivate:: is used in MediaPlayer::installedMediaEngines :(
> > > 
> > > Eric, what do you think we could do?
> > 
> > I agree that the QTKit implementation class name should change, I will do that. 
> > 
> 
> Thanks!
> 
> > Can't you do something like this in any case?
> > 
> > #if PLATFORM(MAC)
> >         MediaPlayerPrivate::registerMediaEngine(addMediaEngine);
> >         MediaPlayerPrivateGStreamer::registerMediaEngine(addMediaEngine);
> > #else
> >         MediaPlayerPrivate::registerMediaEngine(addMediaEngine);
> > #endif
> 
> Hmm but then the gst player won't be compiled for the gtk port. Could we rather
> add a new feature macro and use it like
> 
> #if ENABLE(GSTREAMER)
> ....
> #endif
> 

and register the QTKit player for PLATFORM(MAC) || PLATFORM(WIN) ? Maybe it'd
make sense to have a macro for this feature as well.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.