[Webkit-unassigned] [Bug 36662] Add support for iframe flattening

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36662


Antti Koivisto <koivisto at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51741|review?                     |review+
               Flag|                            |




--- Comment #4 from Antti Koivisto <koivisto at iki.fi>  2010-03-26 08:11:08 PST ---
(From update of attachment 51741)
Looks good, r=me 

I don't have any really substantial comments just one naming objection:

> -    if (flattenFrameSet())
> +    if (shouldResizeFramesToContent())
>          positionFramesWithFlattening();

Why this renaming? The naming was discussed quite a bit, lets stick with the
"flatten" terminology now.

You now have shouldResizeFramesToContent() method in both RenderFrameSet and
RenderPartObject (with rather different semantics), even though those are not
really related classes. Why do they need to have same names? Why not stick with
RenderFrameSet::flattenFrameSet() and add RenderPartObject::flattenFrame() or
similar?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.