[Webkit-unassigned] [Bug 36624] Configure multi-language movies

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36624





--- Comment #6 from Eric Carlson <eric.carlson at apple.com>  2010-03-26 07:51:44 PST ---
(From update of attachment 51694)
> +++ WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm	(working copy)
> @@ -927,6 +927,7 @@ void MediaPlayerPrivate::updateStates()
>  
>      if (loadState >= QTMovieLoadStateLoaded && m_readyState < MediaPlayer::HaveMetadata) {
>          disableUnsupportedTracks();
> +        wkQTMovieSelectPreferredAlternates(m_qtMovie.get());
>          if (m_player->inMediaDocument()) {
>              if (!m_enabledTrackCount || m_hasUnsupportedTracks) {
>                  // This has a type of media that we do not handle directly with a <video> 

We don't know if the movie is playable at this point so you should call
wkQTMovieSelectPreferredAlternates a few lines further down, after checking to
see if the movie opened successfully (near the call to cacheMovieScale).


> Index: WebCore/platform/mac/WebCoreSystemInterface.h
> ===================================================================
> --- WebCore/platform/mac/WebCoreSystemInterface.h	(revision 56339)
> +++ WebCore/platform/mac/WebCoreSystemInterface.h	(working copy)
> @@ -129,6 +129,7 @@ extern float (*wkQTMovieMaxTimeSeekable)
>  extern int (*wkQTMovieGetType)(QTMovie* movie);
>  extern BOOL (*wkQTMovieHasClosedCaptions)(QTMovie* movie);
>  extern void (*wkQTMovieSetShowClosedCaptions)(QTMovie* movie, BOOL showClosedCaptions);
> +extern void (*wkQTMovieSelectPreferredAlternates)(QTMovie* movie);

The parameter name isn't needed here. You might as well get rid of the QTMovie
parameter name on wkQTMovieGetType, wkQTMovieHasClosedCaptions, and
wkQTMovieSetShowClosedCaptions while you are at it.


> Index: WebCore/platform/mac/WebCoreSystemInterface.mm
> ===================================================================
> --- WebCore/platform/mac/WebCoreSystemInterface.mm	(revision 56339)
> +++ WebCore/platform/mac/WebCoreSystemInterface.mm	(working copy)
> @@ -61,6 +61,7 @@ float (*wkQTMovieMaxTimeSeekable)(QTMovi
>  int (*wkQTMovieGetType)(QTMovie* movie);
>  BOOL (*wkQTMovieHasClosedCaptions)(QTMovie* movie);
>  void (*wkQTMovieSetShowClosedCaptions)(QTMovie* movie, BOOL showClosedCaptions);
> +void (*wkQTMovieSelectPreferredAlternates)(QTMovie* movie);

And here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.