[Webkit-unassigned] [Bug 35607] Allow building smoothly on win32 and win64 using GCC

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=35607





--- Comment #33 from Fridrich Strba <fridrich.strba at bluewin.ch>  2010-03-26 01:07:15 PST ---
I looked a bit closer and another two things:
3) In WebCore/platform/text/TextStream.cpp and
WebCore/platform/text/TextStream.h, please remove the " && (COMPILER(MSVC) ||
COMPILER(MINGW64))
"
It has nothing to do with the compiler, just with the size of pointers in on
x64 windows. Whichever compiler will be used will need a 64-bit version of this
function.
4) In JavaScriptCore/runtime/Collector.cpp, please remove the  &&
(COMPILER(MSVC) || COMPILER(MINGW64)).
Reason: The NtCurrentTeb() is not depending on any compiler. It is a standard
entry point in ntdll.dll found already in Windows XP x64 (I don't have any
older version of x64 system). This is the reliable way of getting the stack
base on x64 platform. A Win32 API implementation that does not have that
function defined in winnt.h and and the symbol in ntdll.dll import library is
better off not to try to do x64 compilation because without the information
about the stack base, webkit will not work, so if the compilation breaks there,
it is a good thing :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.