[Webkit-unassigned] [Bug 34539] NP_VERSION_MINOR is not correct for some ports

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=34539


Garth Dahlstrom <ironstorm at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51264|0                           |1
        is obsolete|                            |




--- Comment #7 from Garth Dahlstrom <ironstorm at gmail.com>  2010-03-25 21:43:27 PST ---
Created an attachment (id=51714)
 --> (https://bugs.webkit.org/attachment.cgi?id=51714)
Implements NPN_GetValueForURL and NPN_SetValueForURL, stub for
NPN_GetAuthenticationInfo -- Fixes proxy string logic problem

I've updated the patch to fix the proxy support which had a logic error.

It looks like some corruption is happening in the get value method for cookies.
   This is not seen in the debug statements of either implementation from the
Qt app (this patch provides to functionally identical implementations in Qt and
pure WebKit) but is observed as occasional extra junk being appended to the end
of the Java cookies in the debug console, sometimes it indicates a cookie value
is returned when there is no value supposed to be returned.   

Hosting test browser app:
[2960] npapi.cpp - NPN_GetValueForURL::  Proxy url:
http://www.javatester.org:80/ 
[2960] npapi.cpp - NPN_GetValueForURL::Proxy fetching Proxy from Qt 
[2960] npapi.cpp - NPN_GetValueForURL::Proxy  DIRECT 
[2960] npapi.cpp - NPN_GetValueForURL::  Cookie url:
http://www.javatester.org/JavaVersionDisplayApplet.class 
[2960] npapi.cpp - NPN_GetValueForURL::Cookies [  ] Length: 0 
[2960] len is set before:  0x28d20c 
[2960] len is set after:  0x28d20c 
[2960] len is:  0 

Java Console:
Java Plug-in 1.6.0_17
Using JRE version 1.6.0_17-b04 Java HotSpot(TM) Client VM
...
security: property package.definition new value
com.sun.javaws,com.sun.deploy,com.sun.jnlp,org.mozilla.jss
basic: Added progress listener:
sun.plugin.util.GrayBoxPainter$GrayBoxProgressListener at b166b5
network: Cache entry found [url:
http://www.javatester.org/JavaVersionDisplayApplet.class, version: null]
network: Connecting http://www.javatester.org/JavaVersionDisplayApplet.class
with proxy=DIRECT
network: Connecting http://www.javatester.org:80/ with proxy=DIRECT
network: Connecting http://www.javatester.org/JavaVersionDisplayApplet.class
with cookie "°
REC"   <--- This is junk since there is no value returned from
the host Qt app as far as I can tell.
...

I suspect the problem is something to do with the statements in the if block at
line 36 of the attached patch, however I'm unable to figure out what's
happening (I've tried to implement it 2 ways, results are the same)...   

I'm not very good at low level C/C++, which is hence I use Qt for native
compiled apps...  Maybe I'm doing something obviously wrong (i.e. does the
length pointer thing look okay)?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.