[Webkit-unassigned] [Bug 36394] Include git commits in the diff for webkit-patch upload/land.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36394





--- Comment #17 from Ojan Vafai <ojan at chromium.org>  2010-03-25 16:27:08 PST ---
(In reply to comment #16)
> Maybe a --squash option would let folks use both workflows?  It could be an
> option on both upload and land.

I don't understand what the other workflow is. When is the current workflow
ever superior to the squash workflow?

The current workflow requires all your changes to be in the working copy. The
new one lets you continue doing that if you want, but also lets you have
committed changes. In theory, the current workflow lets you have local commits
that you don't want to upload, but why is that useful if committing to SVN will
commit all your local commits as well?

Adding it isn't a big deal I guess, except for maintenance overhead for a
feature that probably won't get used. I would want it to at least default to
true.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.