[Webkit-unassigned] [Bug 36505] Generated run-in Content is Mistakenly Getting Deleted

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 25 16:04:26 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=36505





--- Comment #10 from Joseph Pecoraro <joepeck at webkit.org>  2010-03-25 16:04:26 PST ---
Just a heads up, besides correctly handling listMarkers I also made an
optimization:

> -        while (first && (!first->isRenderBlock() || first->isFloatingOrPositioned()))
> +        if (!first->isRenderBlock())
> +            return 0;
> +        while (first && first->isFloatingOrPositioned())

Render block sibling should only be render blocks. So I can check once (before
the loop) instead of every iteration. That is what the original isRunIn()
handling code did. Also, a null check for first is handled before.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list