[Webkit-unassigned] [Bug 36449] Expose the width and height scroll bars add to a view to chromium.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36449





--- Comment #5 from David Levin <levin at chromium.org>  2010-03-25 14:35:02 PST ---
(From update of attachment 51311)
This really needs Darin Fisher's review since you are changing the public api,
so these are just some drive by comments.

> Index: WebKit/chromium/public/WebFrame.h
> @@ -141,6 +141,11 @@ public:
>      // height required to display the document without scrollbars.
>      virtual int documentElementScrollHeight() const = 0;
>  
> +    // Return the size scrollbars add to the frame.  This is the width of the

One space before . in comments is the standard WebKit style.

> +    // horizontal scrollbar, and the height of the vertical scrollbar.  A
> +    // nonexistent scrollbar has a width and height of zero.
> +    virtual WebSize scrollbarsSize() const = 0;


> Index: WebKit/chromium/src/WebFrameImpl.cpp
> +WebSize WebFrameImpl::scrollbarsSize() const
> +{
...
> +    if (m_frame) {
> +        WebCore::FrameView *view = m_frame->view();

Incorrect * placement. It should look like this:
WebCore::FrameView* view = m_frame->view();

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.