[Webkit-unassigned] [Bug 36599] test-webkitpy: Should remove *.pyc files in webkitpy/ prior to importing from webkitpy/

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36599


Chris Jerdonek <cjerdonek at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cjerdonek at webkit.org




--- Comment #2 from Chris Jerdonek <cjerdonek at webkit.org>  2010-03-25 12:29:23 PST ---
(In reply to comment #1)
> Huh?  To test-webkitpy would always cause a full python recompile?  That seems
> like a bad idea.

I noticed no perceptible difference between running test-webkitpy with and
without  deleting all *.pyc files before-hand.  It seems like recompiling might
be an order of magnitude or two less than running the tests themselves.  (I
tried to time the difference, but unittest.main() exits before you can execute
a final line.)

Do you have a suggestion for an alternative?  We could always put this behind a
--clean option, but I think it would be good for the bots to do whatever we
come up with by default.

One alternative might be to delete any .pyc file that doesn't have a
corresponding .py, but I don't think that covers all the cases we want to deal
with.  Or maybe delete any *.pyc file that doesn't correspond to a
source-controlled (tracked) *.py file, but I'm also not sure that covers all
the scenarios.  Given that the compile is so fast, it might not be worth the
trouble.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.