[Webkit-unassigned] [Bug 36484] [chromium] correctly handle move drag operations

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36484


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51605|review?                     |review-
               Flag|                            |




--- Comment #9 from David Levin <levin at chromium.org>  2010-03-25 11:43:11 PST ---
(From update of attachment 51605)

> diff --git a/WebKit/chromium/src/WebViewImpl.h b/WebKit/chromium/src/WebViewImpl.h

> +    // Consolidate some common code between starting a drag over a target and
> +    // updating a drag over a target.  If we're starting a drag, |isEntering|
> +    // should be true.
> +    WebDragOperation dragTargetDragEnterOrOver(const WebPoint& clientPoint,
> +                                               const WebPoint& screenPoint,
> +                                               bool isEntering);

"bool isEntering" should be an enum, so it is clearer at the calling site what
the function is being passed (instead of "true/false" be passed into the
function).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.