[Webkit-unassigned] [Bug 33004] NetworkStateNotifierWin.cpp doesn't work always

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 25 11:21:51 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=33004


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #50104|review?                     |review-
               Flag|                            |




--- Comment #9 from David Levin <levin at chromium.org>  2010-03-25 11:21:51 PST ---
(From update of attachment 50104)
There are so many whitespaces (and perhaps newline?) changes in here that it is
hard to review/figure out what changed. Please revert the unnecessary parts of
the change (even if it means using a different editor than you usually do) and
keep the change focused on the fix.

Also, there are changes to remove "onLine()" and "setNetworkAccessAllowed()"
which is only there for QT and these seem totally unrelated to the fix.

So r- due to too many unrelated changes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list