[Webkit-unassigned] [Bug 36597] [v8] Add if ENABLE guard for Worker specific code.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Mar 25 09:59:48 PDT 2010


https://bugs.webkit.org/show_bug.cgi?id=36597


David Levin <levin at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51639|review?                     |review+, commit-queue-
               Flag|                            |




--- Comment #2 from David Levin <levin at chromium.org>  2010-03-25 09:59:48 PST ---
(From update of attachment 51639)
> Index: WebCore/ChangeLog
> +2010-03-25  Kristian Monsen  <kristianm at google.com>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Guarding the function in the header as well.

I'll r+ *but* before committing the patch this line should be changed to the
(new) title of the bug (a WK committer can do this for you right before they
commit the change and I think you have a few nearby).

The problem is that right now this line doesn't tell you anything. Ideally one
should be able to read this and get a sense of what was addressed (so folks can
decide to look at the details or not -- think of it like a good email subject).

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list