[Webkit-unassigned] [Bug 36359] Double clicking page's last editable inline element causes assertion failure.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Mar 25 00:16:42 PDT 2010
https://bugs.webkit.org/show_bug.cgi?id=36359
Shinichiro Hamaji <hamaji at chromium.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #51390|review? |review-
Flag| |
--- Comment #4 from Shinichiro Hamaji <hamaji at chromium.org> 2010-03-25 00:16:42 PST ---
(From update of attachment 51390)
> @@ -175,7 +175,7 @@ static VisiblePosition nextBoundary(const VisiblePosition& c, BoundarySearchFunc
> Node *de = d->documentElement();
> if (!de)
> return VisiblePosition();
> - Node *boundary = n->enclosingBlockFlowElement();
> + Node* boundary = n;
> if (!boundary)
> return VisiblePosition();
> bool isContentEditable = boundary->isContentEditable();
I'm not a good reviewer for this bug, but putting r- because I think we need
some more work to fix the bug completely.
- I think we should remove "if (!boundary)" because it was already checked.
- With this patch, "here" is selected after the double click. Without this
patch, it seems "here" isn't selected so I think you also fixed this issue and
we need a test case for this.
- With the following HTML
<div><span id="target" contentEditable="true">here</span> double click</div>
"here" isn't selected when we double-click the target node. Is this related
bug?
- (this is just a question) don't we also need to modify previousBoundary?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list