[Webkit-unassigned] [Bug 26927] webkit-patch or pre-commit hook should validate reviewer lines before committing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26927


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51586|review?                     |review-
               Flag|                            |




--- Comment #7 from Eric Seidel <eric at webkit.org>  2010-03-24 20:35:50 PST ---
(From update of attachment 51586)
+        os.chdir(self._tool.scm().checkout_root)

That needs a FIXME.

Can we say regexp?
+            if changelog_entry.contents().lower().find("unreviewed"):

re.match("unreviewed", changelog_entry.contents(), re.IGNORECASE)

You could/should even just compile the regexp as a class variable on
ValidateReviewer.

+            error('%s neither lists a valid reviewer nor contains the string
"Unreviewed".')
should note that the search is case insensitive.

I am saddened by the lack of the testzors.

Otherwise this looks great!

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.