[Webkit-unassigned] [Bug 26927] webkit-patch or pre-commit hook should validate reviewer lines before committing

Wed Mar 24 19:24:14 PDT 2010

https://bugs.webkit.org/show_bug.cgi?id=26927

Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51572|review?                     |review-
               Flag|                            |

--- Comment #4 from Eric Seidel <eric at webkit.org>  2010-03-24 19:24:14 PST ---
(From update of attachment 51572)
You are a better man than I.  However, this is sub-optimal (and will break the
case of the ChangeLog posted already having a valid reviewer).

Better would be to look at reviewer() on all the ChangeLogEntries right before
we assemble the commit message.  We could even validate that that reviewer()
matches the one we pulled off the bug, if the bug had one.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.