[Webkit-unassigned] [Bug 36080] Performance degradations when using large javascript files

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=36080


David Leong <david.leong at nokia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #51559|                            |review?
               Flag|                            |




--- Comment #8 from David Leong <david.leong at nokia.com>  2010-03-24 15:32:29 PST ---
Created an attachment (id=51559)
 --> (https://bugs.webkit.org/attachment.cgi?id=51559)
First stab at a patch.

This patch makes JSC::SourceProvider::hasBOMs() virtual so sub classes can
inherit from it. This method is overwritten for both the
CachedScriptSourceProvider and the StringSourceProvider. For the
CachedScriptSourceProvider, I delegated the BOM check to the CachedScript as
the buffer maybe deleted by the decoded data callback timer. For the
StringSourceProvider the BOM check is done when the class is constructed. Both
classes store the results of the BOM check so that repeated calls by the
JSC::Parser for source code will not repeat the BOM checks.

I was thinking should we move the BOM checking to the base class
ScriptSourceProvider? In that case how would we deal with the decoded data
deletion by the CachedScript.

Any feedback or ideas would be greatly appreciated.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.